NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
82 stars 57 forks source link

Clean up code for Formulation in advance of Coastal introduction #815

Closed PhilMiller closed 1 month ago

PhilMiller commented 1 month ago

I want to slot in new code for Coastal total water level (TWL) functionality as cleanly as possible with the existing code base. In particular, it seems like CoastalFormulation should be a natural analog to the existing CatchmentFormulation. A lot of stuff there in the baseFormulation interface right now is specific to the existing lumped catchment models, or is just defunct. I try to clean out what's gotten in my way so far, to make the subsequent additions easier.

Additions

None

Removals

Changes

Testing

  1. Local testing on macOS
  2. CI

Checklist

PhilMiller commented 1 month ago

I think this is mostly in shape to clear the path for Coastal needs. I'm still uncertain about create_formulation, but that could be addressed in a subsequent PR.