search

NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
82 stars 57 forks source link

Ngen shows a NetCDF file closing error after finishing the run when using NetCDF forcing file #818

Closed stcui007 closed 1 month ago

stcui007 commented 1 month ago

This issue is created after today's discussion at the daily stand up. We agreed that there was a need to refresh people's mind about Issue 749, where there were some discussions and details about the issue already. The main point is that we need in our ngen code to close/destruct/cleanup all our files/objects before finishing.

https://github.com/NOAA-OWP/ngen/issues/749

As a reference, there is a rudimentary version that seems to fix the issue: https://github.com/stcui007/ngen/tree/I481_netcdf. Maybe a better design is needed.

Current behavior

Expected behavior

Steps to replicate behavior (include URLs)

1.

Screenshots

PhilMiller commented 1 month ago

Duplicate of the earlier linked issue

stcui007 commented 1 month ago

Yes. The purpose was to remind people to not forget this issue as suggested at a daily standup. Now we are on it, this is not needed.

On Wed, May 29, 2024 at 2:09 PM Phil Miller - NOAA @.***> wrote:

Duplicate of the earlier linked issue

— Reply to this email directly, view it on GitHub https://github.com/NOAA-OWP/ngen/issues/818#issuecomment-2138086752, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACA4SRIE5EIRGHD5DV7BIC3ZEYRXDAVCNFSM6AAAAABHPCWOOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGA4DMNZVGI . You are receiving this because you authored the thread.Message ID: @.***>