Fix #570 by removing support for unimplemented legacy parameters used to configure forcings inputs.
Removals
Bmi_Adapter: delete uses_forcing_file and forcing_file (path) members, construction arguments, and accessors
BMI Formulation classes: stop passing forcing_file arguments through to BMI Adapter classes
Changes
Delete all forcing_file keys in JSON built in test fixtures
Throw errors on affirmative use of the never-active and now-removed configuration options
Testing
ctest
CI
Notes
There may be documentation that should evolve in tandem
Users with legacy realization configs may start to see errors related to this. They've already almost certainly added the right options, since otherwise their runs just wouldn't work. So, fixing things is just a matter of removing the old bits from their files.
Checklist
[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:
Fix #570 by removing support for unimplemented legacy parameters used to configure forcings inputs.
Removals
Bmi_Adapter
: deleteuses_forcing_file
andforcing_file
(path) members, construction arguments, and accessorsforcing_file
arguments through to BMI Adapter classesChanges
forcing_file
keys in JSON built in test fixturesTesting
ctest
Notes
Checklist