We want to build warning-clean, and -Wnon-virtual-dtor can signal some serious potential errors. This PR fixes internal cases that trigger the warning.
Changes
Formulation_Manager and HydrofabricSubsetter: remove virtual marking on member functions, since the classes don't have descendants that need virtual dispatch
geojson::FeatureVisitor: add virtual destructor
Testing
CI
Notes
BMI module class change will come in a separate PR, that changes both our copies and external git submodules together
Checklist
[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:
We want to build warning-clean, and
-Wnon-virtual-dtorcan signal some serious potential errors. This PR fixes internal cases that trigger the warning.Changes
Formulation_Managerand HydrofabricSubsetter: removevirtualmarking on member functions, since the classes don't have descendants that need virtual dispatchgeojson::FeatureVisitor: add virtual destructorTesting
Notes
Checklist