NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
84 stars 62 forks source link

Update all C++ BMI modules to reference virtual destructor #831

Closed PhilMiller closed 3 months ago

PhilMiller commented 3 months ago

https://github.com/csdms/bmi-cxx/pull/12 has been merged. Now we need coordinated updates of our internal and OWP-wide C++ BMI modules to make sure that they all consistently start to reference the revised definition in clean, atomic steps.

Under the model engine team's purview, there's

Under (I think) the Formulation and/or Soil team's purview, there's references in

PhilMiller commented 3 months ago

@nels - I'm calling it a night. Let's talk tomorrow about how to coordinate testing and merging the batch that all need to go together.