search

NOAA-OWP / ngen

Next Generation Water Modeling Engine and Framework Prototype
Other
82 stars 57 forks source link

ci: fix troute build #833

Closed aaraney closed 2 weeks ago

aaraney commented 3 weeks ago

Fix t-route CI builds after changes introduced in https://github.com/NOAA-OWP/t-route/pull/780. https://github.com/NOAA-OWP/t-route/pull/780 at its core addressed the need for the python wheel package as a build time dependency. wheel was not installed in CI before attempting to build t-route. This addresses that. (https://github.com/NOAA-OWP/t-route/pull/782 addressed this).

Edit: The failure was due to a change in setuptools editable installation mode. This change was introduced in setuptools 64 but was not enforced for packages that did not define a pyproject.toml metadata file. In the CI action, setuptools was being updated to the latest version and t-route packages were being installed with --editable mode enable. https://github.com/NOAA-OWP/t-route/pull/780 added pyproject.toml files to t-route packages.

The solution ended up being trivial, just install the packages in normal non-editable mode.

aaraney commented 3 weeks ago

Testing this with the pinned pip dep now just to make sure this solves the issue. Once the tests pass, I will remove the pinning of the pip version in CI and include that as part of this PR.

aaraney commented 2 weeks ago

Okay, so that is getting somewhere. It looks like setuptools or a transient dependency of setuptools is causing the issue (see https://github.com/NOAA-OWP/ngen/actions/runs/9486412729/workflow#L104). Things are passing when setuptools is not upgraded. Going to investigate that now.