Fix t-route integration tests requiring `fiona`

program-- commented 3 months ago

geopandas<1.0.0 included fiona as a required dependency. However, since v1.0.0, they switched to using pyogrio as the default engine for I/O -- as a result, fiona is currently an unspecified dependency in t-route.

Changes

Include fiona in pip install call in CI

Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged / future todos are captured in comments
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

PhilMiller commented 3 months ago

Is there a corresponding fix for t-route itself?

PhilMiller commented 3 months ago

I.e. is the right thing to do to add it to t-route's requirements.txt instead?

program-- commented 3 months ago

Is there a corresponding fix for t-route itself?

Yeah, my brain is frazzled. I did this, but then just reached out to Sean a few minutes ago and realized the actual fix is just to add fiona to the pyproject.toml in troute.network :facepalm:

At the very least, the CI runs here show me that's all the issue is haha

EDIT: https://github.com/NOAA-OWP/t-route/pull/827

NOAA-OWP / ngen

Fix t-route integration tests requiring `fiona` #870

Changes

Checklist