Fix TBOT conflict and hard-coded values - Githubissues

NOAA-OWP / noah-owp-modular

Modularized version of the NOAH-MP land surface model.

Other

9 stars 20 forks source link

Fix TBOT conflict and hard-coded values #114

Open SnowHydrology opened 2 months ago

SnowHydrology commented 2 months ago

This line uses forcing%tbot, which is different than the parameters%tbot here.

BOTH VALUES ARE HARD-CODED—YIKES—AND DIFFERENT.

Forcing: https://github.com/NOAA-OWP/noah-owp-modular/blob/5be0faae07637ffb44235d4783b5420478ff0e9f/src/RunModule.f90#L182

Parameters: https://github.com/NOAA-OWP/noah-owp-modular/blob/5be0faae07637ffb44235d4783b5420478ff0e9f/src/ParametersType.f90#L361

SnowHydrology commented 2 months ago

Note: Noah-MP defines TBOT as a static attribute per grid cell.