Some variable units were transformed to match NWM v3.0 output. However, this should not be done in the model's BMI specification as it affects how variables are passed from one model to another in a NextGen formulation.
This issue is to check the BMI implementation of the main and noah_om_grid branches to ensure variable units are correct and that no transforms are performed in get_value.
Some variable units were transformed to match NWM v3.0 output. However, this should not be done in the model's BMI specification as it affects how variables are passed from one model to another in a NextGen formulation.
For example, we had to revert the change to
water%evapotransso that Noah-OM would once again work when coupled to CFE and TOPMODEL: https://github.com/NOAA-OWP/noah-owp-modular/pull/115This issue is to check the BMI implementation of the
mainandnoah_om_gridbranches to ensure variable units are correct and that no transforms are performed inget_value.See example here of the variable
ECAN, which needs to be fixed: https://github.com/NOAA-OWP/noah-owp-modular/blob/37d8d8257fc083d171fe5c1aee6bd72ddb504a43/bmi/bmi_noahowp.f90#L942For each variable, the developer must update:
output_itemsnoahowp_var_unitsdestvalue innoahowp_get_floatnoahowp_set_float