This PR adds the nowdate variable -- which is a member of domaingrid_type and domain_type -- to the DomainVarOutTransfer subroutine.
Because nowdate is calculated/updated within the scope of solve_noahowp (specifically within the UtilitiesMain subroutine), the updated value must be included within the DomainVarOutTransfer subroutine so that the updated nowdate is available to the subsequent time step call to read_forcing_text. If nowdate is not included, the forcing file is incorrectly read-in.
ADDITIONS
domaingrid%nowdate = domain%nowdate was added to the DomainVarOutTransfer subroutine.
CHANGES
TESTING
/test/analysis/compare_outputnc.py was executed and grid cell (1,1) passed all tests while other grid cells did not pass all tests.
NOTES
This was a difficult bug to find. I was working on a PR for the read NetCDF file functions and could not get /test/analysis/compare_outputnc.py to pass tests for gric cell (1,1). I assumed that my changes related to the new PR were causing the problem. However, I found that the problem was due to my removing nowdate from the DomainVarOutTransfer subroutine in PR #82.
I think the best solution would be to calculate/advance domaingrid_type%nowdate outside the scope of solve_noahowp, then transfer nowdate into domain_type prior to calling solve_noahowp, then don't worry about transferring nowdate back out to domaingrid_type because there is no need to do so.
PURPOSE
This PR adds the
nowdatevariable -- which is a member ofdomaingrid_typeanddomain_type-- to theDomainVarOutTransfersubroutine.Because
nowdateis calculated/updated within the scope ofsolve_noahowp(specifically within theUtilitiesMainsubroutine), the updated value must be included within theDomainVarOutTransfersubroutine so that the updatednowdateis available to the subsequent time step call toread_forcing_text. Ifnowdateis not included, the forcing file is incorrectly read-in.ADDITIONS
domaingrid%nowdate = domain%nowdatewas added to theDomainVarOutTransfersubroutine.CHANGES
TESTING
/test/analysis/compare_outputnc.pywas executed and grid cell (1,1) passed all tests while other grid cells did not pass all tests.NOTES
This was a difficult bug to find. I was working on a PR for the read NetCDF file functions and could not get
/test/analysis/compare_outputnc.pyto pass tests for gric cell (1,1). I assumed that my changes related to the new PR were causing the problem. However, I found that the problem was due to my removing nowdate from theDomainVarOutTransfersubroutine in PR #82.I think the best solution would be to calculate/advance
domaingrid_type%nowdateoutside the scope ofsolve_noahowp, then transfernowdateintodomain_typeprior to callingsolve_noahowp, then don't worry about transferringnowdateback out todomaingrid_typebecause there is no need to do so.