To fix handling of SNOWT_AVG and ACSNOM variables that were added to the gridded branch in PR #86.
Changes
SNOWT_AVG was being set to huge(1.) when there was no snow/ice. However, this PR changes the way SNOWT_AVG calculated such that SNOWT_AVG will be -999999.0 when there is no snow/ice. See PR #91 and this comment specifically for further explanation.
This PR adds SNOWT_AVG to energy_type%InitDefault, energy_type%TransferIn, and energy_type%TransferOut because SNOWT_AVG should have been present in these subroutines but was not. This problem surfaced when I reexamined the unit test output for SNOWT_AVG (after changing our means of calculating SNOWT_AVG as described in the first bullet point above) but did not see expected values for the variable in the unit test output.
Note that PR #86 included SNOWT_AVG in the transfer in/out subroutines but this change was mistakenly undone by PR #89
This PR adds ACSNOM to water_type%InitDefault, water_type%TransferIn, and water_type%TransferOut because ACSNOM should have been present in these subroutines but was not. This problem surfaced when I reexamined the unit test output (after changing our means of calculating SNOWT_AVG as described in the first bullet point above) but did not see expected values for the variable in the unit test output.
Note that PR #86 included ACSNOM in the transfer in/out subroutines but this change was mistakenly undone by PR #89
Purpose
To fix handling of
SNOWT_AVG
andACSNOM
variables that were added to the gridded branch in PR #86.Changes
SNOWT_AVG
was being set tohuge(1.)
when there was no snow/ice. However, this PR changes the waySNOWT_AVG
calculated such thatSNOWT_AVG
will be-999999.0
when there is no snow/ice. See PR #91 and this comment specifically for further explanation.This PR adds
SNOWT_AVG
toenergy_type%InitDefault
,energy_type%TransferIn
, andenergy_type%TransferOut
becauseSNOWT_AVG
should have been present in these subroutines but was not. This problem surfaced when I reexamined the unit test output forSNOWT_AVG
(after changing our means of calculatingSNOWT_AVG
as described in the first bullet point above) but did not see expected values for the variable in the unit test output.SNOWT_AVG
in the transfer in/out subroutines but this change was mistakenly undone by PR #89This PR adds
ACSNOM
towater_type%InitDefault
,water_type%TransferIn
, andwater_type%TransferOut
becauseACSNOM
should have been present in these subroutines but was not. This problem surfaced when I reexamined the unit test output (after changing our means of calculatingSNOWT_AVG
as described in the first bullet point above) but did not see expected values for the variable in the unit test output.ACSNOM
in the transfer in/out subroutines but this change was mistakenly undone by PR #89Testing