When encountering an error, NoahOM prints an error message to console immediately prior to stopping the model with a call to stop. However, because the call to stop prevents the BMI update or update_until functions from finishing, NextGen is unable to report time and location (i.e., catchment id) information to the model-user along with the error message.
Expected behavior
When encountering an error, NoahOM should return to the BMI update or update_until functions and indicate that an error has occurred along with any recorded error messaging.
Suggested changes
Remove calls to stop in the NoahOM code base
When encountering an error, save the error message and record that an error has occurred using a flag/logical variable
Add code to BMI update function to check for an error flag value and returns BMI_FAILURE and writes the message
Current behavior
When encountering an error, NoahOM prints an error message to console immediately prior to stopping the model with a call to
stop. However, because the call tostopprevents the BMIupdateorupdate_untilfunctions from finishing, NextGen is unable to report time and location (i.e., catchment id) information to the model-user along with the error message.Expected behavior
When encountering an error, NoahOM should return to the BMI
updateorupdate_untilfunctions and indicate that an error has occurred along with any recorded error messaging.Suggested changes
stopin the NoahOM code baseupdatefunction to check for an error flag value and returnsBMI_FAILUREand writes the messagereturnrather thanstopNotes