We had a need to upgrade README.md and INSTALL.md to be fully match v2 code and patterns. This also triggered some images updates and additions. The file changes based on this adjustments are not listed here.
There are a couple of linting changes as well:
Changes
src
conflate_hecras_to_nwm.py: linting
create_geocurves.py: linting
Testing
page editing for the two markdown files.
ras2fim.py was re-tested to ensure it is still stable.
Checklist
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[x] Informative and human-readable title, using the format: [_pt] PR: <description>
[x] Pre-commit executed and linting changes made.
[ ] n/a - Links are provided if this PR resolves an issue, or depends on another other PR
[x] If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g.: dev-revise-levee-masking)
[ ] Changes are limited to a single goal (no scope creep)
[x] The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
We had a need to upgrade README.md and INSTALL.md to be fully match v2 code and patterns. This also triggered some images updates and additions. The file changes based on this adjustments are not listed here.
There are a couple of linting changes as well:
Changes
src
conflate_hecras_to_nwm.py
: lintingcreate_geocurves.py
: lintingTesting
Checklist
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.:dev-revise-levee-masking
)dev
branchMerge Checklist (For Technical Lead use only)