search

NOAA-OWP / snow17

Other
4 stars 10 forks source link

Initial migration of a snow17 FORTRAN source code into the OWP Snow17 repository #1

Closed andywood closed 2 years ago

andywood commented 2 years ago

This PR contains an adapted version of the original Snow17SacUH code that has had all the Sac & UH functionality stripped out so that the driver only runs the Snow17 model. It includes a test case for the Flathead River inflows to Hungry Horse reservoir made up of two snow bands. It was debugged, and compiled and ran with the gfortran compiler on Cheyenne.

SnowHydrology commented 2 years ago

@andywood The code runs for me with some mods to the makefile. At first the model wouldn't build. I tracked the issue down here:

# compile calibration code
model:
    $(FC77) $(FLAGS77) -c $(calib_pgf77) $(INC77)
    $(FC) $(FLAGS2) -c $(calib_pgf90_2) $(INC)
    $(FC) $(FLAGS) -c $(calib_pgf90) $(DRIVER) \
    $(INC)

calib_pgf77 is undefined in the makefile. Are the Fortran77 lines remnants from a previous Snow-17 version? If so, it looks like most of them can be deleted. I will do that if you confirm they're not needed.

andywood commented 2 years ago

I think this is a line I should have deleted related to compiling the sac or duamel / routing part of the code that has since been deleted. I'll confirm and update the PR. thanks!

On Wed, Feb 16, 2022 at 7:33 AM K. Jennings @.***> wrote:

@andywood https://github.com/andywood The code runs for me with some mods to the makefile. At first the model wouldn't build. I tracked the issue down here:

compile calibration code

model: $(FC77) $(FLAGS77) -c $(calib_pgf77) $(INC77) $(FC) $(FLAGS2) -c $(calib_pgf90_2) $(INC) $(FC) $(FLAGS) -c $(calib_pgf90) $(DRIVER) \ $(INC)

calib_pgf77 is undefined in the makefile. Are the Fortran77 lines remnants from a previous Snow-17 version? If so, it looks like most of them can be deleted. I will do that if you confirm they're not needed.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-OWP/snow17/pull/1#issuecomment-1041554012, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARJGOKIVZT6P6CCOT33U3OYUTANCNFSM5OPUZBRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

andywood commented 2 years ago

I removed those f77 lines and retested both the regular and debug compilations using gfortran on cheyenne.