search

NOAA-OWP / snow17

Other
4 stars 10 forks source link

update Master with first running version of Snow17 BMI development #10

Closed andywood closed 2 years ago

andywood commented 2 years ago

Complete first version of snow17 with BMI driver. Rewrite and restructure of original NCAR version archived at: https://github.com/NCAR/NWS_hydro_models

Includes a test case with two snowbands for the SF Flathead R / Hungry Horse Reservoir inflows, with restart capabilities. The rewrite converted to using BMI functions to drive the model and consolidated datatype classes.

It was tested against the original version on NCAR Cheyenne with the gfortran compiler, and found to a very close but not perfect match to output from a prior run. This is likely due to converting many datatypes to single precision from double precision and omitting the use of nrtype specifications.

andywood commented 2 years ago

@Keith and Naoki, perhaps take a quick look. I'm not sure this is reviewable since the version in master before was incomplete. Let me know if you have any comments or want to test it yourself, otherwise I will go ahead and merge it.