search

NOAA-OWP / snow17

Other
4 stars 10 forks source link

adding changes to bmi_snow17 units and other updates that were missed… #24

Closed andywood closed 2 years ago

andywood commented 2 years ago

… in the last commit (small)

stcui007 commented 2 years ago

Hi Andy, I was trying to build snow17 in the standalone mode using gfortran on UCS linux servers yesterday in the build/ directory using the Makefile there. I got an error caused by "-fcheckall". Change to "-fcheck=all" make it work as you have it elsewhere in the same file. I have the link attached below: https://github.com/NOAA-OWP/snow17/blob/master/build/Makefile#L48-L50

Shengting

On Wed, Nov 2, 2022 at 10:09 AM Andy Wood @.***> wrote:

Merged #24 https://github.com/NOAA-OWP/snow17/pull/24 into master.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-OWP/snow17/pull/24#event-7724371607, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACA4SRLC2PLDKYNCZHA6253WGJ73VANCNFSM6AAAAAARVFXBQU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SnowHydrology commented 2 years ago

@andywood, can you fix this when you have a moment? I committed the changes a few months ago in #17 and tagged you for review.

Thank you @stcui007 for the reminder.