search

NOAA-OWP / snow17

Other
4 stars 10 forks source link

Correcting skipped assignments in the forcing module when snow17 is run in nextgen, one of which led to melt errors. #48

Closed andywood closed 2 months ago

andywood commented 3 months ago

Moved two assignments from the read_areal_forcing() routing in ioModule into the solve_snow() routing in runSnow17 module. One assigned surface pressure forcing, and the other stored the scaled pcp for output. Without this change, pressure (PA) is unassigned when the model is run in nextgen, leading to melt errors.

Testing

The updated code was compiled and run for the test case (ex1), yielding identical outputs to the original code; the compiler was gfortran and OS was linux (NCAR derecho login node).

Notes

This bug was diagnosed and fixed by Josh Sturtevant and Andy Wood (CO School of Mines).

SnowHydrology commented 2 months ago

@drakest123 If you approve this PR, you can mark it as such and merge it. Please let me know if you want help with that.