search

NOAA-OWP / t-route

Tree based hydrologic and hydraulic routing
Other
40 stars 45 forks source link

`awk` call is now gnu and bsd compliant. fixes #720 #722

Closed aaraney closed 5 months ago

aaraney commented 5 months ago

See #720 for more detail.

Changes

shorvath-noaa commented 5 months ago

@JoshCu Could you test that this PR works on your end?

JoshCu commented 5 months ago

@JoshCu Could you test that this PR works on your end?

Absolutely :) I should have thought to do that before I introduced the bug. What needs testing? containerized on mac, native on mac, both? linux too?

shorvath-noaa commented 5 months ago

@JoshCu I guess just on whatever set up you originally wrote this fix for. Thanks!

On Thu, Jan 11, 2024 at 2:15 PM Joshua Cunningham @.***> wrote:

@JoshCu https://github.com/JoshCu Could you test that this PR works on your end?

Absolutely :) I should have thought to do that before I introduced the bug. What needs testing? containerized on mac, native on mac, both? linux too?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-OWP/t-route/pull/722#issuecomment-1887973597, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYSH2PPPALUPMJP3ICKZ4ULYOBI7LAVCNFSM6AAAAABBTPWEJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBXHE3TGNJZG4 . You are receiving this because you commented.Message ID: @.***>

JoshCu commented 5 months ago

image All working for next gen container and test data on x86

aaraney commented 5 months ago

I tested it in a container on apple arm64 and it worked for me too!