This fix provides a solution when lastobs_df is empty because no usgs data is available while stream nudging is unknowingly activated in the config file. More solid solution will be provided soon. Also, in diffusive_routing mainstem_list now has a list of stream segments aligned in order from upstream to downstream. Moreover, missing topobathy data for a stream segment get filled in by looking up the newly aligned list.
Additionns
AbstractRouting.py
removed sort() to mainstem_list to align a list of stream segments in order from upstream to downstream
modified the way to search for an upstream segment id for a given mainstem segment that has no channel xsec topobathy data
DataAssimilation.py
Added a condition not to call new_lastobs function when there is no lastobs related values updated from mc_reach.pyx
output.py
Added a condition not to call lastobs_df_output when there is no lastobs related values updated from mc_reach.pyx
Removals
-
Changes
-
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:
This fix provides a solution when lastobs_df is empty because no usgs data is available while stream nudging is unknowingly activated in the config file. More solid solution will be provided soon. Also, in diffusive_routing mainstem_list now has a list of stream segments aligned in order from upstream to downstream. Moreover, missing topobathy data for a stream segment get filled in by looking up the newly aligned list.
Additionns
AbstractRouting.py
DataAssimilation.py
output.py
Removals
-
Changes
-
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist
Target Environment support
Accessibility
Other