Primarily, this PR is to address erroneous behavior that appeared if t-route did not find any lakes in a given geopackage (as is, for example, the case in the coastal bayous in Texas). Secondarily, unnecessary function calls were also avoided for such cases.
Additions
If statements in HYFeaturesNetwork.py, DataAssimilation.py, compute.py
Removals
-
Changes
-
Testing
Running, e.g., Cedar Bayou with reservoir DA enabled.
Screenshots
Notes
-
Todos
-
Checklist
[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:
Primarily, this PR is to address erroneous behavior that appeared if t-route did not find any lakes in a given geopackage (as is, for example, the case in the coastal bayous in Texas). Secondarily, unnecessary function calls were also avoided for such cases.
Additions
Removals
-
Changes
-
Testing
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist
Target Environment support
Accessibility
Other