NOAA-OWP / t-route

Tree based hydrologic and hydraulic routing
Other
40 stars 45 forks source link

Avoid unnecessary (and potentially erroneous) calls when no lakes are present. #750

Closed JurgenZach-NOAA closed 2 weeks ago

JurgenZach-NOAA commented 3 months ago

Primarily, this PR is to address erroneous behavior that appeared if t-route did not find any lakes in a given geopackage (as is, for example, the case in the coastal bayous in Texas). Secondarily, unnecessary function calls were also avoided for such cases.

Additions

Removals

-

Changes

-

Testing

  1. Running, e.g., Cedar Bayou with reservoir DA enabled.

Screenshots

Notes

-

Todos

-

Checklist

Testing checklist

Target Environment support

Accessibility

Other

JurgenZach-NOAA commented 2 weeks ago

Due to the fact that this PR was in the queue since March, it's easier to start a new one than try to fix this one.