Quick updates to config module/retrieval. Set default values for columns if user leaves this parameter blank. This includes a @validator to set defaults based on whether it is a NHDNetwork or HYFeaturesNetwork.
Also fixed retrieving rfc_da parameters in read_geopkg() function. This was looking for these parameters in waterbody_parameters which was the old method. Now looks in data_assimilation_parameters where they actually are for V4.
Additions
network_topology_parameters.py
Default values for columns for both NHD and HYFeatures networks
@validator to set appropriate default values based on network_type
Removals
-
Changes
HYFeaturesNetwork.py
Updated where rfc_da parameters are retrieved from
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:
Quick updates to config module/retrieval. Set default values for
columns
if user leaves this parameter blank. This includes a@validator
to set defaults based on whether it is aNHDNetwork
orHYFeaturesNetwork
.Also fixed retrieving
rfc_da
parameters inread_geopkg()
function. This was looking for these parameters inwaterbody_parameters
which was the old method. Now looks indata_assimilation_parameters
where they actually are for V4.Additions
network_topology_parameters.py
columns
for both NHD and HYFeatures networks@validator
to set appropriate default values based onnetwork_type
Removals
-
Changes
HYFeaturesNetwork.py
rfc_da
parameters are retrieved fromTesting
1.
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist
Target Environment support
Accessibility
Other