NOAA-OWP / t-route

Tree based hydrologic and hydraulic routing
Other
43 stars 48 forks source link

Fix config issues relating to 'columns' default values and retrieving rfc da parameters #751

Closed shorvath-noaa closed 6 months ago

shorvath-noaa commented 6 months ago

Quick updates to config module/retrieval. Set default values for columns if user leaves this parameter blank. This includes a @validator to set defaults based on whether it is a NHDNetwork or HYFeaturesNetwork.

Also fixed retrieving rfc_da parameters in read_geopkg() function. This was looking for these parameters in waterbody_parameters which was the old method. Now looks in data_assimilation_parameters where they actually are for V4.

Additions

network_topology_parameters.py

Removals

-

Changes

HYFeaturesNetwork.py

Testing

1.

Screenshots

Notes

-

Todos

-

Checklist

Testing checklist

Target Environment support

Accessibility

Other