Too high values of the celerity in the diffusive Fortran kernel often lead to too small (sometimes several orders of magnitude smaller than on second), which virtually freezes the kernel. To prevent it from happening, upper limits on celerity are placed after deriving from the Courant condition with minimum simulation time increment being initially given time step divided by an user-provided numeric value (10 in this case).
Additions
diffusive.f90: Once validated, the user-provided numeric value, for better use, should be directly passed from config yaml or through diffusive_util_v02.py
Removals
-
Changes
-
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:
Too high values of the celerity in the diffusive Fortran kernel often lead to too small (sometimes several orders of magnitude smaller than on second), which virtually freezes the kernel. To prevent it from happening, upper limits on celerity are placed after deriving from the Courant condition with minimum simulation time increment being initially given time step divided by an user-provided numeric value (10 in this case).
Additions
diffusive.f90: Once validated, the user-provided numeric value, for better use, should be directly passed from config yaml or through diffusive_util_v02.py
Removals
-
Changes
-
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist
Target Environment support
Accessibility
Other