NOAA-OWP / t-route

Tree based hydrologic and hydraulic routing
Other
40 stars 45 forks source link

Updates to handle problematic waterbody data #764

Closed shorvath-noaa closed 1 month ago

shorvath-noaa commented 2 months ago

Two major updates:

  1. Fix issue of duplicate integer IDs between some waterbodies and stream segments. We now add a large number to any duplicate waterbody ID initially, then revert back to the original ID before writing output files.
  2. Some waterbodies have flowpaths that physically lie within them, but are not referenced to the waterbody ID. This causes issues when collapsing segment IDs into a single waterbody ID in our connections dictionary (multiple "downstream" IDs which violates the DAG). These waterbodies are simply "dropped" as waterbodies, meaning the underlying segments are used for MC routing.

Additions

-

Removals

-

Changes

AbstractRouting.py

HYFeaturesNetwork.py

output.py

main.py

Testing

  1. Successfully ran a dummy (unrealistic forcing inputs) CONUS run with waterbodies enabled.
  2. Verified output files contain original IDs.

Screenshots

Notes

-

Todos

-

Checklist

Testing checklist

Target Environment support

Accessibility

Other