NOAA-OWP / t-route

Tree based hydrologic and hydraulic routing
Other
43 stars 48 forks source link

DataAssimilation logger #786

Closed AminTorabi-NOAA closed 3 months ago

AminTorabi-NOAA commented 3 months ago

Previously, t-route was logging without specifying where the logging was happening. In this update:

1. Named Loggers: Each file now has a specific logger name. 2. Data Assimilation Logging: Added logging to the dataAssimilation.py file to record execution times. 3. Custom Log Directory: The YAML configuration file now includes a log_directory option. By uncommenting this, you can specify the directory where log files should be saved. 4. Execution Order: The log file now records the order in which files are executed.

Additions

-

Removals

-

Changes

-

Testing

1.

Screenshots

image

Notes

-

Todos

-

Checklist

Testing checklist

Target Environment support

Accessibility

Other

shorvath-noaa commented 3 months ago

Can you also verify that all these change work if you change the showtiming parameter to False?

shorvath-noaa commented 3 months ago

Can you also verify that all these change work if you change the showtiming parameter to False?

@AminTorabi-NOAA did you test this with showtiming set to False? I think it will throw an error, and if so can you fix it?