NOT READY TO MERGE
This contains a few updates to run on v2.2 of the hydrofabric. These edits have been focused on producing valid output for the inland/coastal coupling exercise. The main features are working with v2.2 of the hydrofabric, accessing gage crosswalk information for streamflow nudging, and accessing POI crosswalk information that is now included in the stream_output output files.
TODO
We will need to ensure backwards compatibility with older versions of the hydrofabric. This might not be necessary eventually, but for the time being I believe users are still running t-route on older versions, so we want to maintain that.
Additions
Retrieve and pass along poi_crosswalk info from the hydrofabric to output files.
Removals
-
Changes
Access gage information from a new location in the hydrofabric.
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:
NOT READY TO MERGE This contains a few updates to run on v2.2 of the hydrofabric. These edits have been focused on producing valid output for the inland/coastal coupling exercise. The main features are working with v2.2 of the hydrofabric, accessing gage crosswalk information for streamflow nudging, and accessing POI crosswalk information that is now included in the
stream_outputoutput files.TODO We will need to ensure backwards compatibility with older versions of the hydrofabric. This might not be necessary eventually, but for the time being I believe users are still running t-route on older versions, so we want to maintain that.
Additions
poi_crosswalkinfo from the hydrofabric to output files.Removals
-
Changes
Testing
1.
Screenshots
Notes
-
Todos
-
Checklist
Testing checklist
Target Environment support
Accessibility
Other