search

NOAA-OWP / wres

Code and scripts for the Water Resources Evaluation Service
Other
2 stars 1 forks source link

As a user, when a WRDS JSON source has a missing comId, then the application should EITHER handle that OR stop elegantly #200

Open epag opened 2 months ago

epag commented 2 months ago

Author Name: James (James) Original Redmine Issue: 60672, https://vlab.noaa.gov/redmine/issues/60672 Original Date: 2019-02-25

Expected behavior:

Given a declaration that requires the ingest of a WRDS JSON source that does not contain a "comId" attribute, when I execute that declaration, then the application should EITHER:

  1. Stop elegantly, without a @NullPointerException@ and indicate that the WRDS JSON format does not accept a missing "comId" (IF that is true) OR;
  2. It should proceed to ingest the source, handling the missing "comId" IF that is acceptable use of the WRDS JSON format.

Deliberately vague because I don't know what the WRDS JSON format demands w/r to required versus accepted metadata.

Actual behavior:

See #60500-49 and #60500-50. To reproduce, attempt to ingest a WRDS JSON source that does not have a "comId" attribute.

Redmine related issue(s): 60500

epag commented 2 months ago

Original Redmine Comment Author Name: James (James) Original Date: 2019-02-25T18:33:09Z

Fixing typo.