NOAA-OWP / wres

Code and scripts for the Water Resources Evaluation Service
Other
2 stars 1 forks source link

As a user, I want the example COWRES scripts to work "out of the box" post-4.0 deployment to production #243

Open epag opened 3 months ago

epag commented 3 months ago

Author Name: Jesse (Jesse) Original Redmine Issue: 85739, https://vlab.noaa.gov/redmine/issues/85739 Original Date: 2020-12-08


See #85730 The scripts still refer to -dev and -ti. Ideally they should not have hostname patterns baked in, allow for specification of the COWRES hostname.

epag commented 3 months ago

Original Redmine Comment Author Name: Jesse (Jesse) Original Date: 2020-12-08T18:01:28Z


Estimate includes testing all of python, shell, R programs after changes. It has been a while since running the python or R programs, may be difficult to get them up and running.

epag commented 3 months ago

Original Redmine Comment Author Name: Jesse (Jesse) Original Date: 2020-12-08T19:28:29Z


First most obvious step is simple find/replace without any testing at all, in commit:8fafef68f568d7341799acfa99d7c57258d1146a

epag commented 3 months ago

Original Redmine Comment Author Name: James (James) Original Date: 2024-06-25T10:30:44Z


Assume this will be addressed as part of the github migration because hostname patterns should not be in our codebase at all.

epag commented 3 months ago

Original Redmine Comment Author Name: Hank (Hank) Original Date: 2024-06-25T12:29:14Z


James wrote:

Assume this will be addressed as part of the github migration because hostname patterns should not be in our codebase at all.

Worth noting the bash and Python run scripts we mention in the wiki already do not refer to specific hosts; the user is expected to point the script to the host. So its other scripts which may or may not exist that should be addressed through the migration, as you said.

Hank