NOAA-PMEL / Ferret

The Ferret program from NOAA/PMEL
https://ferret.pmel.noaa.gov/Ferret/
The Unlicense
55 stars 20 forks source link

ensemble members with _FillValue not missing_value, bad-data mishandled #1449

Closed karlmsmith closed 6 years ago

karlmsmith commented 6 years ago

Reported by @AnsleyManke on 12 May 2014 18:52 UTC Patrick Brockmann reported this. When the variables in member datsets have only a _FillValue attribute and it's different from Ferret's default, Ferret doesn't apply the missing flag to the incoming, member data when computing with the ensemble data.

        double maize_yield(lat, lon) ;
                maize_yield:standard_name = " Maize harvest" ;
                maize_yield:long_name = " Maize harvest" ;
                maize_yield:units = "kgC.m-2.yr-1" ;
                maize_yield:_FillValue = 9.96920996838687e+36 ;
                maize_yield:online_operation = "ave(scatter(X))" ;
                maize_yield:interval_operation = 1800.f ;
                maize_yield:interval_write = -1.f ;

Which is perfectly legal of course. The aggregation needs to apply the missing/Fill value for the incoming member data when loading data into the result(the aggregated dataset variable).

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2177

karlmsmith commented 6 years ago

Comment by @AnsleyManke on 12 May 2014 20:45 UTC Fixed in is_aggregate_gather.F