NOAA-PMEL / OAPDashboard

The Upload Dashbord for the Ocean Acidifiation Project
The Unlicense
0 stars 2 forks source link

Requiring a user to input an NCEI Accession number for revision/appending requests #38

Open lqjiang opened 2 years ago

lqjiang commented 2 years ago

In the "submit to archive" step, if a user is making a revision/appending submission (instead of a new submission), can we modify the system so that the Accession number field will become compulsory? We need this info to make sure to modify the correct data set. NCEI's automation system would also need this information to check if a previous help desk ticket has already been created or not.

Thanks

Liqing

lkamb commented 2 years ago

Yes, that is a good idea and doable.

We'll probably want to have some support / clarification for when it's an update to a dataset that does not yet have an accession, eg a dataset was submitted through SDIS, then a change was made and the dataset was resubmitted before an accession was provided.

lqjiang commented 2 years ago

Thanks, Linus.

If a data set has never been submitted to NCEI yet, it is a new submission. How many times they were submitted to the SDIS before they were forward to NCEI should not matter.

lkamb commented 2 years ago

Yes, but if they submit to NCEI, and then realize they need to make a change and resubmit before an accession has been granted, they will have to use the SDIS record ID (or leave it blank.)

On Thu, Nov 18, 2021 at 10:24 AM lqjiang @.***> wrote:

Thanks, Linus.

If a data set has never been submitted to NCEI yet, it is a new submission. How many times they were submitted to the SDIS before they were forward to NCEI should not matter.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NOAA-PMEL/OAPDashboard/issues/38#issuecomment-973139725, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZO4R7CZMACKNMHJP4GZBDUMVAGFANCNFSM5IJSOEXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Linus Kamb

NOAA / PMEL + UW / CICOES office: 206.526.4356 cell: 206.795.7934

lqjiang commented 2 years ago

Hi Linus,

Thank you for the comments!

Revision and Appending are reserved for data sets that have already been published at NCEI. This is dictated by how NCEI's version control system works. Before a data set is published, any changes will be made in our "ingest area" and are not considered a revision. After it is published, the user would have known the NCEI Accession number through the publication confirmation email.

No user should try to submit a revision before their data is even published at NCEI. In the rare situation as you described, they should just send an email to noaa.ocads@noaa.gov and explain to us what they want to change. They also have the choice of waiting for the data set to be published first and then submit a revision.

Liqing

lkamb commented 2 years ago

Interesting.

That is not currently enforced.

On Thu, Nov 18, 2021 at 12:26 PM lqjiang @.***> wrote:

Hi Linus,

Thank you for the comments!

Revision and Appending are reserved for data sets that have already been published at NCEI. This is dictated by how NCEI's version control system works. Before a data set is published, any changes will be made in our "ingest area" and are not considered a revision. After it is published, the user would have known the NCEI Accession number through the publication confirmation email.

No user should try to submit a revision before their data is even published at NCEI. In the rare situation as you described, they should just send an email to @.*** and explain to us what they want to change. They also have the choice of waiting for the data set to be published first and then submit a revision.

Liqing

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NOAA-PMEL/OAPDashboard/issues/38#issuecomment-973234328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZO4RYUXTIIH22IQ7N6BR3UMVOQNANCNFSM5IJSOEXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Linus Kamb

NOAA / PMEL + UW / CICOES office: 206.526.4356 cell: 206.795.7934