ZZZ-REDUNDANT: Move the "create the DA yaml file" into the DA_update.

jiaruidong2017 commented 1 year ago

PR Instructions:

Provide details under all headings below.
Assign Clara and one other person as reviewers.
If the PR is not ready for merging, add the "DRAFT/DO NOT MERGE" label.
When a PR is ready to merge, remove the "DRAFT/DO NOT MERGE" and email Clara.
Before requesting that the PR be merged, complete the checklist below.

Notes on preparing PR, using git can be found in README_git

Describe your changes

Summarise all code changes included in PR: Update the scripts to handle the missing observation data from the different sources (GTS, GHCN, IMS, etc.). The JEDI DA yaml file is originally created in the submit_cycle, and now is created in the do_snowDA script based on the availability of the obs files.

List any associated PRs in the submodules. https://github.com/noaa-psd/land-DA_update/pull/2

Issue ticket number and link

List the git Issue that this PR addresses: https://github.com/noaa-psd/land-offline_workflow/issues/6

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?

Does it pass the DA_IMS_test?

If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:

Checklist before requesting a review

[X] My branch being merged is up to date with the latest develop.
[X] I have performed a self-review of my code by examining the differences that will be merged.
[X] I have not made any unnecessary code changes / changed any default behavior.
[ ] My code passes the DA_IMS_test, or differences can be explained.

ClaraDraper-NOAA commented 1 year ago

@jiaruidong2017 This part looks fine. Does it pass the IMS test?

ClaraDraper-NOAA commented 1 year ago

Closing this PR until the associated land-DAupdate PR is ready.

NOAA-PSL / land-offline_workflow