search

NOAA-PSL / land-offline_workflow

Creative Commons Zero v1.0 Universal
1 stars 9 forks source link

Update CMake modules to be consistent with GFS / GDAS #20

Open ClaraDraper-NOAA opened 1 year ago

ClaraDraper-NOAA commented 1 year ago

A recent PR from @jkbk2004 added ecbuild / CMake as a second option for compilation, since merging the land DA into GDASApp will require compilation with ecbuild. We have confirmed that it compiles, and runs, but the output is not zero-diff with the current make build (make), since each system uses different compilation flags.

Currently, the ecbuild is using the same modules as soca (and does not work on hera - Clara will update this to add a temporary option for hera ).

Once @CoryMartin-NOAA has finalized the new modules (spack-stack?) for compiling GDASApp, we need to switch the ecbuild system for this repo to use all of the same modules, compilation flags, etc as GDASApp. We then need to check that the differences from the current system are as expected (insignificant differences due to compilation flags), remove the current make system, and update the test output to be based on the new ecbuild output.

CoryMartin-NOAA commented 1 year ago

@ClaraDraper-NOAA we are using spack-stack now and I think it seems to be working okay, see: https://github.com/NOAA-EMC/GDASApp/blob/develop/modulefiles/GDAS/hera.lua