Merge EPIC/release/public v1.0.0 into PSL/release/EPIC1.0 - Githubissues

NOAA-PSL / land-offline_workflow

Creative Commons Zero v1.0 Universal

1 stars 12 forks source link

Merge EPIC/release/public v1.0.0 into PSL/release/EPIC1.0 #28

Closed rhaesung closed 5 months ago

rhaesung commented 1 year ago

PR Instructions:

Provide details under all headings below.
Assign Clara and one other person as reviewers.
If the PR is not ready for merging, add the "DRAFT/DO NOT MERGE" label.
When a PR is ready to merge, remove the "DRAFT/DO NOT MERGE" and email Clara.
Before requesting that the PR be merged, complete the checklist below.

Notes on preparing PR, using git can be found in README_git

Describe your changes

Summarise all code changes included in PR:

List any associated PRs in the submodules.

Issue ticket number and link

List the git Issue that this PR addresses:

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?

Does it pass the DA_IMS_test?

If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:

Checklist before requesting a review

[ ] My branch being merged is up to date with the latest develop.
[ ] I have performed a self-review of my code by examining the differences that will be merged.
[ ] I have not made any unnecessary code changes / changed any default behavior.
[ ] My code passes the DA_IMS_test, or differences can be explained.

jkbk2004 commented 1 year ago

with issue #29 open, @rhaesung can you convert back this pr to draft?