NOAA-PSL / land-offline_workflow

Creative Commons Zero v1.0 Universal
1 stars 9 forks source link

Update EMC HR3 model setup #31

Closed YoulongXia-NOAA closed 2 days ago

YoulongXia-NOAA commented 3 months ago

PR Instructions:

  1. Provide details under all headings below.
  2. Assign Clara and one other person as reviewers.
  3. If the PR is not ready for merging, add the "DRAFT/DO NOT MERGE" label.
  4. When a PR is ready to merge, remove the "DRAFT/DO NOT MERGE" and email Clara.
  5. Before requesting that the PR be merged, complete the checklist below.

Notes on preparing PR, using git can be found in README_git

Describe your changes

Summarise all code changes included in PR:

List any associated PRs in the submodules.

Update ufs-land-driver from Draper's Fork into https://github.com/NOAA-EMC/ufs-land-driver to keep consistent with driver update.

Issue ticket number and link

List the git Issue that this PR addresses:

https://github.com/NOAA-PSL/land-offline_workflow/issues/30

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?

Does it pass the DA_IMS_test?

If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:

Checklist before requesting a review

YoulongXia-NOAA commented 3 months ago

@ClaraDraper-NOAA and @barlage, I tested C96 HR3 and run 2-day test successfully. Now I summarized my modifications below: (1) work with Mike Barlage to update ufs-land-driver. Now it is linking emc public github rather than Draper fork. The purpose is easily updated for land model and driver in the future (2) In submit_cycle.sh, add copy parameter table to run directory. This is a key step if new model is run. (3) In settings_cycle_test, (1a) update new orography fix directory - /scratch2/NCEPDEV/land/data/fix/20231027. Note that there is no oro_C96.mx100 files as used before. I made a soft link in my directory - /scratch1/NCEPDEV/da/Youlong.Xia/landDA/fix/hr3/, (1b) I put the initials in /scratch2/NCEPDEV/land/Youlong.Xia/landDA/era5_ICS/. The original C96 HR3 start file is in /scratch2/NCEPDEV/land/Michael.Barlage/spinup_hr3/ufs-land-driver/run/spinup_C96. (4) In both template.vector2tile and template.tile2vector, use hr3 static files (5) In template.ufs-noahMP.namelist.era5, I updated all hr3 model setup besides output. (6) My run results are in /scratch2/NCEPDEV/land/Youlong.Xia/landDA/cycle_land/DA_test_era5/

This is what I did right now. Please review this PR and let me know your suggestions/comments. Thank you.

ClaraDraper-NOAA commented 2 days ago

@YoulongXia-NOAA I had to make two changes to get it to run: -update the fix directory in the vector2tile template