NOAA-PSL / land-offline_workflow

Creative Commons Zero v1.0 Universal
1 stars 9 forks source link

add directory for applying perturbation #9

Closed zhichang-guo closed 1 year ago

zhichang-guo commented 2 years ago

PR Instructions:

  1. Provide details under all headings below.
  2. Assign Clara and one other person as reviewers.
  3. If the PR is not ready for merging, add the "DRAFT/DO NOT MERGE" label.
  4. When a PR is ready to merge, remove the "DRAFT/DO NOT MERGE" and email Clara.
  5. Before requesting that the PR be merged, complete the checklist below.

Notes on preparing PR, using git can be found in README_git

Describe your changes

Summarise all code changes included in PR: Add directory and codes for applying perturbation to vegetation fraction

List any associated PRs in the submodules. None

Issue ticket number and link

List the git Issue that this PR addresses: https://github.com/noaa-psd/land-offline_workflow/issues/3

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)? Yes

Does it pass the DA_IMS_test? Yes

If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:

Checklist before requesting a review

ClaraDraper-NOAA commented 1 year ago

@zhichang-guo Can you please resolve the conflicts in this PR so that we can get it merged?

ClaraDraper-NOAA commented 1 year ago

@zhichang-guo I think so. You also closed the PR though - can you please re-open it? ( I don't seem to be able to).

zhichang-guo commented 1 year ago

After I resolved the conflicts, the PR has been automatically closed. So reopen it. I think it's ready to be merged.

ClaraDraper-NOAA commented 1 year ago

Thanks @zhichang-guo I'll have a look later today.

ClaraDraper-NOAA commented 1 year ago

Thanks @zhichang-guo . I've merged it.