search

NOAA-PSL / stochastic_physics

Contains the stochastic physics pattern generator for the Unified Forecast System
Other
6 stars 41 forks source link

Roughness length is added to lndp_apply_perts.F90 #34

Closed tanyasmirnova closed 3 years ago

tanyasmirnova commented 3 years ago

Roughness length is added to the perturbed variables over land with lndp_type = 2.

pjpegion commented 3 years ago

Are there an any associated PRs in fv3atm or ccpp?

climbfuji commented 3 years ago

This PR should have been made to the noaa-gsl fork, branch gsl/develop.

tanyasmirnova commented 3 years ago

@pjpegion @ClaraDraper-NOAA Yes, there is a change in the wrapper in the FV3/stochastic_physics that adds this variable to the parameter list.

climbfuji commented 3 years ago

@pjpegion @ClaraDraper-NOAA Yes, there is a change in the wrapper in the FV3/stochastic_physics that adds this variable to the parameter list.

But those changes are in the NOAA-GSL fork, branch gsl/develop. Please close this PR and reopen it for that fork/branch. Thanks!

tanyasmirnova commented 3 years ago

@pjpegion @climbfuji I apologize for making this PR in noaa-psd space. For some reason, I was pointed to this directory when I made a change for roughness length stochastic perturbations. I am closing this PR and opening another one.

pjpegion commented 3 years ago

No worries

On Tue, Jan 12, 2021 at 1:41 PM tanyasmirnova notifications@github.com wrote:

@pjpegion https://github.com/pjpegion @climbfuji https://github.com/climbfuji I apologize for making this PR in noaa-psd space. For some reason, I was pointed to this directory when I made a change for roughness length stochastic perturbations. I am closing this PR and opening another one.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/noaa-psd/stochastic_physics/pull/34#issuecomment-758953075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJIRVJEEAGEKEVGIAEQGRITSZSXZDANCNFSM4V7V5LWQ .

-- Philip Pegion (he/him/his) NOAA/Physical Sciences Laboratory-CIRES (303) 497-7897 philip.pegion@noaa.gov