search

NOAA-SWPC / IPE

Ionosphere Plasmasphere Electrodynamics Model
GNU General Public License v3.0
6 stars 10 forks source link

Ipe trim #32

Closed twfang closed 4 years ago

twfang commented 4 years ago

I have removed many subroutines in IPE that are not used. I have also tested the coupled run with SWIO and the results are bit-by-bit the same. Please quickly go through the code and see if you want to delete more stuff. I would like to get this into develop branch so that Raffale can use this version for further development.

The document shows what has been removed from the current develop branch. https://docs.google.com/spreadsheets/d/1tknk5FejQKCpZbmNZi11yr7GSpNgXWj1ZGYRaO9JjtA/edit#gid=0

akubaryk commented 4 years ago

If the results are bitwise identical, I don't see any problem with this at all (although maybe we should test a standalone run, too? I can do this). Do we think there's any need to tag a pre-purge version for any reason, or are we fine with leaving them deep in the commit history?

akubaryk commented 4 years ago

Per discussion this morning, pre-trim tag has been created if there's any need to easily reference the code deleted with this PR.