ZhuxiaoLi66
commented
2 years ago Will take a look tomorrow. Thanks, Zhuxiao
On Tue, Jul 12, 2022 at 1:39 PM akubaryk @.***> wrote:
@SvetlanaKarol-NOAA https://github.com/SvetlanaKarol-NOAA noted this issue via email. There's an incorrect type error in idea_solar_heating.f https://github.com/NOAA-SWPC/WAM/blob/421547ea7ce97e53c0ba404b17e32f2eef5a97b0/src/phys/idea_solar_heating.f#L259 that leads to dayno being interpreted as effectively 0 in the subroutine solar_heat_dissociation_TIEGCM. As a result, sfeps is always a little over 1.03363, while the value should vary like this according to day of year:
[image: image] https://user-images.githubusercontent.com/31134616/178579045-03d1630a-c69e-45fe-b868-1c19340461d4.png
a difference of almost 6.5% in the NH summer.
A branch bugfix/solar_heating will be pushed shortly -- we should identify the impact on the model.
— Reply to this email directly, view it on GitHub https://github.com/NOAA-SWPC/WAM/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMARC7XK6UCVAAVVUWSD3TVTXCWDANCNFSM53MEO67Q . You are receiving this because you were assigned.Message ID: @.***>
@SvetlanaKarol-NOAA noted this issue via email. There's an incorrect type error in idea_solar_heating.f that leads to
daynobeing interpreted as effectively 0 in the subroutinesolar_heat_dissociation_TIEGCM. As a result,sfepsis always a little over 1.03363, while the value should vary like this according to day of year:a difference of almost 6.5% in the NH summer.
A branch
bugfix/solar_heatingwill be pushed shortly -- we should identify the impact on the model.