search

NOC-MSM / SE-NEMO

Shelf Enabled Global NEMO
GNU General Public License v3.0
2 stars 1 forks source link

out of bound array #92

Closed yutiPML closed 1 year ago

yutiPML commented 1 year ago

in MY_SRC_GO8_FROZEN/icethd_pnd.F90 line 650 zTavg is calculated using an out of bound value for the index jl

I suspect that instead of dividing by a single (non-existing) value of a_i, it should be divided by the sum of a_i along the third axis.

However, zTavg is defined as local variable (line 519), calculated (lines 645-650) but never used.

quick fix is to comment line 650

This problem is only highlighted when the code is compiled with -fcheck=all

jdha commented 1 year ago

@chris-O-wilson & @jasontempestholt updated code - now in master.