search

NOC-MSM / pyBDY

pyBDY: a Python based regional NEMO model configuration toolbox.
GNU General Public License v3.0
7 stars 7 forks source link

Bathymetry tests (unit test 001) #104

Open JMorado opened 1 year ago

JMorado commented 1 year ago

Closes #101

jdha commented 1 year ago

Hi @JMorado - just wondering if you have time to get this ready for merging? If you need a hand let me know!

JMorado commented 1 year ago

Hi @jdha,

The unit test test_child_grid_colocated is ready and passes on my local repo. The issue is that we did several ad hoc changes to the main code to "generalise" it, otherwise it would not run. Probably, we should take a closer look at those changes to check that they do not break anything else before pushing them to this branch?

I am also happy to go ahead and finish the test_child_grid_rotated test, but I will probably need some help as, as far I remember, I was getting other errors coming from other parts of the code...

I think to have #138 ready would be easier in order to have some unit test examples (I expect that no major changes are required to other parts of the code in these)...Maybe @rdPatmore and I could meet for 15 minutes just to set the refactoring plan and then go ahead with the writing of the tests?

Let me know what are your thoughts on this.

jdha commented 1 year ago

Hi @jdha,

The unit test test_child_grid_colocated is ready and passes on my local repo. The issue is that we did several ad hoc changes to the main code to "generalise" it, otherwise it would not run. Probably, we should take a closer look at those changes to check that they do not break anything else before pushing them to this branch?

I am also happy to go ahead and finish the test_child_grid_rotated test, but I will probably need some help as, as far I remember, I was getting other errors coming from other parts of the code...

I think to have #138 ready would be easier in order to have some unit test examples (I expect that no major changes are required to other parts of the code in these)...Maybe @rdPatmore and I could meet for 15 minutes just to set the refactoring plan and then go ahead with the writing of the tests?

Let me know what are your thoughts on this.

Happy either way - I just thought I'd mention this after having a conversation with @jpolton. He was thinking of creating a few tests for the tide code and couldn't find the unit test example in the main repo. If #138 is easier, happy to help with that - you could even pop a quick unit test in to make sure the refactoring doesn't alter the Boundary Class when using the benchmark data.