plot_coords.py: basemap-->cartopy

NOC-MSM / pyBDY

pyBDY: a Python based regional NEMO model configuration toolbox.

GNU General Public License v3.0

7 stars 7 forks source link

plot_coords.py: basemap-->cartopy #123

Closed jpolton closed 1 year ago

jpolton commented 1 year ago

Convert use of basemap to cartopy in plot_coords.py

Note this also requires cartopy to be invoked in the environment and package build.

(For now I am adding cartopy, rather than replacing basemap. As I am not confident that basemap does not have other dependencies.) Update: remove basemap

Acceptance Criteria:

[x] the following produce a beautiful basemap-free plot (@jdha)

python plotting/plot_coords.py outputs/NNA_R12_bdyT_y1979m11.nc outputs/coordinates.bdy.nc

[x] happy with the settings edits in yaml etc files (@JMorado)

jdha commented 1 year ago

(For now I am adding cartopy, rather than replacing basemap. As I am not confident that basemap does not have other dependencies.)

The only other basemap dependancy is in src/pybdy/gui so I'd be happy to remove basemap and return to the gui at a later date. The fact is the gui hasn't been used for years so will definitely need attention.

jdha commented 1 year ago

You can remove base map from the pyproject.toml file too - if you don't and use pip install -e . then basemap still gets installed.

jdha commented 1 year ago

Also it would be nice to remove the blue from the interior of the domain (as in the old figure) ... no drama if that's awkward to implement. We can revisit later.

jdha commented 1 year ago

Ha! Scuppered at the last hurdle! There was me thinking I could sneak a cheeky update through - and GitHub says my review doesn't count as I was part of the development cycle! Now we need @JMorado to review too... good safety net!