Closed jpolton closed 1 year ago
(For now I am adding cartopy, rather than replacing basemap. As I am not confident that basemap does not have other dependencies.)
The only other basemap dependancy is in src/pybdy/gui so I'd be happy to remove basemap and return to the gui at a later date. The fact is the gui hasn't been used for years so will definitely need attention.
You can remove base map from the pyproject.toml file too - if you don't and use pip install -e .
then basemap still gets installed.
Also it would be nice to remove the blue from the interior of the domain (as in the old figure) ... no drama if that's awkward to implement. We can revisit later.
Ha! Scuppered at the last hurdle! There was me thinking I could sneak a cheeky update through - and GitHub says my review doesn't count as I was part of the development cycle! Now we need @JMorado to review too... good safety net!
Convert use of
basemap
tocartopy
inplot_coords.py
Note this also requires
cartopy
to be invoked in the environment and package build.(For now I am adding cartopy, rather than replacing basemap. As I am not confident that basemap does not have other dependencies.) Update: remove basemap
Acceptance Criteria: