#138 Refactoring and Testing of the Boundary Class

NOC-MSM / pyBDY

pyBDY: a Python based regional NEMO model configuration toolbox.

GNU General Public License v3.0

7 stars 7 forks source link

#138 Refactoring and Testing of the Boundary Class #150

Open JMorado opened 12 months ago

JMorado commented 12 months ago

This PR introduces the following modifications, addressing issue #138:

Restructured the Boundary class for improved functionality.
Implemented unit and functional tests for the Boundary class, which is defined within the nemo_bdy_gen_c.py file. The original version of the Boundary class can be found in the nemo_bdy_gen_c_old.py file.

JMorado commented 8 months ago

@jdha, the docstrings are now consistent with the format used throughout the rest of the codebase.

Additionally, it appears that updating the cookiecutter template using make template-update is necessary. Any merging conflicts arising from this update should be resolved to ensure the successful completion of the pre-commit step in the CI workflow. In spite of that, I believe this PR is ready for merging, as this update is a separate issue.

rdPatmore commented 4 months ago

This was never merged? Can we get these changes incorporated?