NOC-MSM / pyBDY

pyBDY: a Python based regional NEMO model configuration toolbox.
GNU General Public License v3.0
7 stars 7 forks source link

setup.py install copies espg incorrectly #50

Closed thopri closed 4 years ago

thopri commented 4 years ago

When running setup.py install the espg for basemap that is required is copied over as a directory containing the file rather than the file itself resulting in a build error. Hacky fix is to copy the espg file up one level and delete the directory called epsg.

thopri commented 4 years ago

On second testing it seems to work? Will look further but for now it seems to be ok. I may have not cleared my environment correctly.

jdha commented 4 years ago

my original fix to copy over the espg file seems to work on the master for me.... the only issue I came across was an error if that file already existed. The setup.py should first check that the file is absent before copying it over

thopri commented 4 years ago

Yes I am not sure what happened, it worked fine when I tried to recreate the issue.

Sent from my iPhone

On 2 Mar 2020, at 20:01, jdha notifications@github.com wrote:



my original fix to copy over the espg file seems to work on the master for me.... the only issue I came across was an error if that file already existed. The setup.py should first check that the file is absent before copying it over

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/NOC-MSM/PyNEMO/issues/50?email_source=notifications&email_token=AJ2BRDTX3RM6A6DXU2IOX6LRFQF7PA5CNFSM4K7UZ3M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQXOAA#issuecomment-593590016, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ2BRDUOQXK6NH2YD3PZDJLRFQF7PANCNFSM4K7UZ3MQ.

This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. The National Oceanography Centre (NOC) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. NOC does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses. Opinions, conclusions or other information in this message and attachments that are not related directly to NOC business are solely those of the author and do not represent the views of NOC.