search

NOC-MSM / pyBDY

pyBDY: a Python based regional NEMO model configuration toolbox.
GNU General Public License v3.0
7 stars 7 forks source link

bug fixes for missing meridional velocity extraction #77

Closed jdha closed 2 years ago

jdha commented 2 years ago

Addressing ticket #75

jpolton commented 2 years ago

@jdha just noticed that this is still in draft... Some comments anyway: 1) PyNEMO is hard to read, maybe all codes are. With an intention to help new users become new contributors, I think it would be a good idea to be liberal about adding one line comments about what is going on when we make edits. 2) I'm sure when this pull request is finished you will provide a test that must be passed. Even if it is a statement about the error that no longer stops the code.

jdha commented 2 years ago

@jpolton re 2) I just need to verify the output before removing draft status re 1) This is not something I'm concerned about at the moment - main focus is getting the benchmark working + tides, then getting meaningful CI and code coverage sorted before tidying. This is a long term goal - the class structure and subroutines need to be trimmed down. There are several routines in odd places, the extract routines are just a sprawling mess.

jdha commented 2 years ago

Tracer and 3D velocity extraction works [results to be verified] Barotropic vels + SSH extraction missing a whole bunch of code.

Next steps: Run pynemo for each ln_tra, ln_dyn2d, ln_dyn3d and combinations thereof

jdha commented 2 years ago

ln_tra, ln_dyn2d, ln_dyn3d run and complete individually - however, ln_dyn2d + ln_tra is broken also need to remove the 3D vels write-out if only ln_dyn2d requested