search

NOP0 / rustmatic

PLC programming in Rust!
Apache License 2.0
35 stars 2 forks source link

Process image #11

Closed NOP0 closed 4 years ago

NOP0 commented 4 years ago

Just a reality check on this draft.

NOP0 commented 4 years ago

@Michael-F-Bryan I guess this branch also needs some cleanup/bringing it up to standards before merging. (fmt, docstrings etc). Should I do a "clean" PR when we have resolved the discussions?

Michael-F-Bryan commented 4 years ago

Should I do a "clean" PR when we have resolved the discussions?

I'll leave that to you to decide.

At work I like to keep my git history clean and make sure unrelated features are given their own branch, but that's mainly because leaving behind a "paper trail" is useful for tracking changes, discussion, and accountability. I'm not sure if we need to be as formal here though, seeing as it's a relatively small project and we're just doing it in our spare time.

NOP0 commented 4 years ago

Closed because of change of approach.