search

NOP0 / rustmatic

PLC programming in Rust!
Apache License 2.0
35 stars 2 forks source link

Process image simple #28

Closed NOP0 closed 4 years ago

NOP0 commented 4 years ago

First attempt. There's some ergonomics issues with the Adress in userspace I think, and we should also be able to write to the process image from userspace. Wrap in refcell?

Thoughts?

NOP0 commented 4 years ago

I've clicked "resolve" on conversations that I myself feel are resolved. Is this ok, or do you want to resolve these yourself?

Michael-F-Bryan commented 4 years ago

@NOP0 that should be fine. Normally I'll let GitHub mark items as resolved when the corresponding like gets changed. But looking through, I think we're both happy with the resolved bits.

NOP0 commented 4 years ago

@Michael-F-Bryan I guess this ProcessImage is finally nearing mergable if you agree.

Missing is docstrings and tests though, anything else missing?

Michael-F-Bryan commented 4 years ago

I think we should be good. Wanna hit the green merge button?