NOSALRO / robot_dart

RobotDART: a versatile robot simulator for robotics and machine learning researchers
https://nosalro.github.io/robot_dart/
BSD 2-Clause "Simplified" License
50 stars 25 forks source link

Remarks on the documentation #212

Closed c-joly closed 1 month ago

c-joly commented 4 months ago

Hi @costashatz, here are some comments about the documentation, linked to my review on JOSS https://github.com/openjournals/joss-reviews/issues/6771

In my opinion, the API documentation is not enough. It looks to be limited to the automatic generation of the C++ API but without more comment. Moreover, there is no API doc of the Python version. Ideally, a complete documentation inside the source code should be added (e.g. Python Doctoring, doxygen). However, the FAQ provides some very useful examples that can help for most cases. Thus, I do not ask a complete API documentation to validate the JOSS review, but at least to complete some examples with more comments. Some examples files were sometimes difficult to understand directly. Here are some examples taken from the Python samples:

Examples in pendulum.py:

Example in example_parallel.py

Example in HelloWorld.py

Example in cameras.py

These are some examples, there are other lines of code in the examples that are not obvious to understand and that do not come with a comment. On the other hand, some files are very well commented like robot_properties.py which is very helpful to understand how to personalize a robot. Can you review the different C++ and Python examples and add comments to the lines that may be difficult to understand directly?

costashatz commented 1 month ago

@c-joly I think that this is already tackled. We have added a few comments in the code and explained the situation for example_parallel.py in the docs. Feel free to re-open if we have forgotten something or you feel that this is not properly addressed.