String -> Identifier. WIP.

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system

https://nova-team.github.io

GNU Lesser General Public License v3.0

66 stars 23 forks source link

String -> Identifier. WIP. #229

Closed SoniEx2 closed 7 years ago

SoniEx2 commented 7 years ago

This closes #227. Depends on #226 (not for any technical reasons tho).

~~Still a lot of things to work out, see all the TODOs and FIXMEs scattered across the code.~~

Still a few things to work out. (How do I test this in-game?)

codecov-io commented 7 years ago

Current coverage is 13.88% (diff: 17.07%)

Merging #229 into master will increase coverage by 0.12%

@@             master       #229   diff @@
==========================================
  Files           387        394     +7   
  Lines         10839      10993   +154   
  Methods           0          0          
  Messages          0          0          
  Branches       1547       1561    +14   
==========================================
+ Hits           1491       1526    +35   
- Misses         9271       9383   +112   
- Partials         77         84     +7

Powered by Codecov. Last update 70a4f22...4f5cef8

ExE-Boss commented 7 years ago

Due to inactivity of the author, I’m taking over this PR at #238.

SoniEx2 commented 7 years ago

Can this be re-opened?

SoniEx2 commented 7 years ago

The game runs, at least. Not sure how to test if it actually works tho.