search

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system
https://nova-team.github.io
GNU Lesser General Public License v3.0
66 stars 23 forks source link

Minecraft 1.11 wrappers #231

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

PR has been moved to: #234

I’ve begun work on wrappers for Minecraft 1.11. Depends on:

To do list:

Completed:

P.S.: I will do my best to not let NOVA die just yet, I just hope that life won’t get in the way of that.

liach commented 7 years ago

https://github.com/NOVA-Team/NOVA-Core#nova-is-no-longer-maintained

ExE-Boss commented 7 years ago

@liach Yes, I know, but that won’t stop me from making the Minecraft 1.11 wrappers anyway.

codecov-io commented 7 years ago

Current coverage is 13.47% (diff: 15.50%)

Merging #231 into master will decrease coverage by 0.28%

@@             master       #231   diff @@
==========================================
  Files           387        394     +7   
  Lines         10839      11087   +248   
  Methods           0          0          
  Messages          0          0          
  Branches       1547       1568    +21   
==========================================
+ Hits           1491       1494     +3   
- Misses         9271       9502   +231   
- Partials         77         91    +14

Powered by Codecov. Last update 70a4f22...ef77313

calclavia commented 7 years ago

@ExE-Boss If you manage to get it working, I'll be happy to merge stuff

ExE-Boss commented 7 years ago

One question though, should the package be nova.core.wrapper.mc.forge.v111 or nova.core.wrapper.mc.forge.v1_11? I vote for the second option, as it’s clearer than the first and won’t be as likely to conflict.

RX14 commented 7 years ago

@ExE-Boss Second option

SoniEx2 commented 7 years ago

I love you @ExE-Boss

ExE-Boss commented 7 years ago

Debugging the TileEntityTransformer class will be very difficult for me, as this is my first time dealing with Java bytecode directly and ForgeGradle has no :debugClient task, without which breakpoints can’t be used.

As for the bug itself, it seems to have something to do with the changes it does to the TileEntity class causing NullPointerException to be thrown inside the ObjectWeb ASM library.

RX14 commented 7 years ago

@ExE-Boss can you come on IRC?

ExE-Boss commented 7 years ago

Wouldn’t it be easier to use Discord? I have already set it up (with permission from shadowfacts).

RX14 commented 7 years ago

@ExE-Boss set what up where?

ExE-Boss commented 7 years ago

[Link removed]

SoniEx2 commented 7 years ago

Relevant xkcd: http://xkcd.com/1782/

ExE-Boss commented 7 years ago

PR has been moved to: #234