Closed ExE-Boss closed 7 years ago
@@ master #232 diff @@
==========================================
Files 386 387 +1
Lines 10787 10839 +52
Methods 0 0
Messages 0 0
Branches 1537 1547 +10
==========================================
+ Hits 1439 1491 +52
Misses 9271 9271
Partials 77 77
Powered by Codecov. Last update 1026510...f1f9dda
Done now.
@RX14 I’ve implemented all the changes that you’ve requested and I now consider this PR feature complete. If there’s anything else you’d like to add, feel free to say it.
It would be nice if you could hit 100% branch coverage on the file (codecov), but I don't consider it essential. For example you should test raising behaviour, and there are a few partials where short-cut evaluation means the right side of an &&
expression is never evaluated.
@RX14 I’ve now reached 100% Code Coverage on the file, as you requested. The PR is now ready to be reviewed and merged.
This PR will move EnumSelector from Worldgen to Core.
Reason:
EnumSelector seems like a class that would benefit more from being in Core than in Worldgen.
Other changes:
It is now possible to write:
Instead of needing to write: