[RFC] Move events to their correct event class as inner classes

NOVA-Team / NOVA-Monorepo

The core API of the NOVA voxel game modding system

https://nova-team.github.io

GNU Lesser General Public License v3.0

66 stars 23 forks source link

[RFC] Move events to their correct event class as inner classes #233

Closed ExE-Boss closed 7 years ago

ExE-Boss commented 7 years ago

This PR does some work on #192.

Depends on:

~~#229~~ (dependency removed)

To do list:

[ ] ~~Consider moving other events as well~~ (Leave that for another PR)

Completed:

[x] Move ItemRegistrationEvent to ItemEvent as ItemEvent.Register
[x] Move ItemIDNotFoundEvent to ItemEvent as ItemEvent.IDNotFound

codecov-io commented 7 years ago

Current coverage is 13.76% (diff: 33.33%)

Merging #233 into master will increase coverage by <.01%

@@             master       #233   diff @@
==========================================
  Files           387        387          
  Lines         10839      10842     +3   
  Methods           0          0          
  Messages          0          0          
  Branches       1547       1547          
==========================================
+ Hits           1491       1492     +1   
- Misses         9271       9273     +2   
  Partials         77         77

Powered by Codecov. Last update 70a4f22...6d7327e

RX14 commented 7 years ago

Cleaned up and merged into master